Skip to content
This repository has been archived by the owner on May 2, 2019. It is now read-only.

Highlight the existence of git 'tree' object type to distinguish it (e.g. from file system tree) #239

Merged
merged 1 commit into from Oct 5, 2013

Conversation

dsbonev
Copy link
Contributor

@dsbonev dsbonev commented Jul 27, 2012

No description provided.

@jnavila
Copy link
Member

jnavila commented Nov 2, 2012

And rewording it like :

When you create the commit by running git commit, Git checksums each subdirectory list (in this case, just the root project directory) and stores those as tree objects in the Git repository. Git then creates a commit object that has the metadata and a pointer to the root project tree so it can re-create that snapshot when needed.

@GArik
Copy link
Contributor

GArik commented Dec 3, 2012

Not a typo.

And rewording it like :

When you create the commit by running git commit, Git checksums each subdirectory list (in this case, just the root project directory)

What is "subdirectory list"?

@jnavila
Copy link
Member

jnavila commented Dec 3, 2012

It is the list of the content of subdir. Yes, maybe expanding the phrase as "Git checksums the list of the content of each subdirectory" would be better. A pity that the only people concerned by rewordings are not native english speakers...

@GArik
Copy link
Contributor

GArik commented Dec 3, 2012

"Git checksums the list of the content of each subdirectory"

Doesn't seem correct to me as well. Really, the figure below this paragraph explains what is stored better then words :)

A pity that the only people concerned by rewordings are not native english speakers...

Yeah. I think we can leave this part alone until someone will write a better description.

@wakatara
Copy link

Agreed. Just swooping in from Code Triage, but I'd suggest a complete rewriting of the paragraph if you find it that confusing (git is, so not arguing with you, but as a native English speaker it seemed alright to me, so perhaps the person who felt that might be the issue could re-write the entire paragraph segment and submit it. Otherwise, I think we should close this issue.

@dsbonev
Copy link
Contributor Author

dsbonev commented Feb 25, 2013

How about this way:

By running git commit Git checksums each directory and each file and stores those as tree and blob object types respectively in the Git repository. Git then creates a commit object type that has the metadata and a pointer to the root project tree object so it can re-create that snapshot when needed.

@wakatara
Copy link

Sounds good to me. Ship it!... =]

@GArik
Copy link
Contributor

GArik commented Feb 26, 2013

The new variant is not perfectly correct IMO. On git commit Git checksums only project's subdirectories. Files are checksummed on git add.

By running git commit Git checksums

I think that dropping "When you create the commit" part makes the sentence incorrect.

tree and blob object types
commit object type

Doesn't look correct either.

@jnavila
Copy link
Member

jnavila commented Oct 5, 2013

Seems OK to me.

jnavila added a commit that referenced this pull request Oct 5, 2013
Highlight the existence of git 'tree' object type to distinguish it (e.g. from file system tree)
@jnavila jnavila merged commit c267f27 into progit:master Oct 5, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants